fix(e2e-suite): fix passphrase-cardano, add debugging for Solana fees #22235
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two issues in end-to-end test suites: fixes a timeout issue in the Cardano passphrase test and adds debugging capabilities for investigating Solana fee validation failures that occur specifically in CI environments.
- Increased timeout for device connection status check in Cardano passphrase test
- Added comprehensive debugging for Solana fee validation with Redux state inspection
- Extracted common Redux state access logic into a reusable helper method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| swap-coins.test.ts | Added debugging information for Solana fee validation failures with detailed error messages |
| passphrase-cardano.test.ts | Increased timeout for device connection status check from default to 15 seconds |
| enhancePage.ts | Extracted Redux state access into reusable getReduxObject method and refactored existing methods to use it |
| const debugFeeInfo = JSON.stringify( | ||
| await page.getReduxObject('wallet.trading.composedTransactionInfo'), | ||
| null, | ||
| 2, | ||
| ); |
There was a problem hiding this comment.
Consider adding error handling around the Redux state access and JSON.stringify operations to prevent test failures if the state is unavailable or contains circular references.
| const debugFeeInfo = JSON.stringify( | |
| await page.getReduxObject('wallet.trading.composedTransactionInfo'), | |
| null, | |
| 2, | |
| ); | |
| let debugFeeInfo: string; | |
| try { | |
| const reduxObj = await page.getReduxObject('wallet.trading.composedTransactionInfo'); | |
| debugFeeInfo = JSON.stringify(reduxObj, null, 2); | |
| } catch (err) { | |
| debugFeeInfo = `Could not serialize Redux transaction info: ${err}`; | |
| } |
Copilot uses AI. Check for mistakes.
| await expect(page.getByTestId('@deviceStatus-connected')).toBeVisible({ | ||
| timeout: 15_000, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Same performance degradation as we saw in t2t1-recovery-persistence.test.ts test. I have message ready for tech connect channel, I just asked our qa for quick confirmation on real devices.
Description
Related Issue
Resolve
Screenshots:
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents