Emit pin request in THP handshake with interactions #22261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekrjpolak
requested review from
martykan,
mroz22 and
szymonlesisz
as code owners
marekrjpolak
force-pushed
the
feat/thp-handshake-pin-modal
branch
from
4454b0a to
aad345f
Compare
|
Soft locked device is connected as unacquired and requires Pin unlock & THP confirmation when device call is made on suite-native. 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup of #22146 which removes the
tryToUnlockvariant ofThpHandshakeInitRequestin initial device handshake (so the device is without any interaction connected as unacquired, with busy statuspin-locked) and emits the PIN button request in every other consecutive handshake attempt (where the device is already known to Suite so it can show the popup).🔍🖥️ Suite native android test results: View in Currents