Skip to content

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Oct 7, 2025

Since all platforms need this kind of flag, moving it to suite-common.

πŸ”πŸ–₯️ Suite web test results: View in Currents

πŸ”πŸ–₯️ Suite desktop test results: View in Currents

πŸ”πŸ–₯️ Suite native android test results: View in Currents

@yanascz yanascz requested a review from a team as a code owner October 7, 2025 11:29
@yanascz yanascz self-assigned this Oct 7, 2025
@yanascz yanascz added this to BT/THP Oct 7, 2025
@github-project-automation github-project-automation bot moved this to Todo in BT/THP Oct 7, 2025
@yanascz yanascz moved this from Todo to In Progress in BT/THP Oct 7, 2025
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

);

export const selectIsBluetoothDeviceOsUnpairingRequired = (state: NativeBluetoothRootState) =>
selectIsDeviceOsUnpairingRequired(state);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is useless, can you call selectIsDeviceOsUnpairingRequired directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, there's type mismatch.

@yanascz yanascz force-pushed the refactor/bluetooth-os-unpairing branch 2 times, most recently from 7e5ebda to 9735b37 Compare October 7, 2025 12:12
@yanascz yanascz force-pushed the refactor/bluetooth-os-unpairing branch from 9735b37 to dc2254c Compare October 7, 2025 12:22
@yanascz yanascz merged commit 3c555e6 into develop Oct 7, 2025
34 of 45 checks passed
@yanascz yanascz deleted the refactor/bluetooth-os-unpairing branch October 7, 2025 12:38
@github-project-automation github-project-automation bot moved this from In Progress to Needs QA in BT/THP Oct 7, 2025
@pavelmario pavelmario moved this to πŸ”Ž Needs review in Suite Desktop Oct 7, 2025
@pavelmario pavelmario moved this from πŸ”Ž Needs review to 🀝 Needs QA in Suite Desktop Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs QA
Status: 🀝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants