Skip to content

Conversation

the-david-oy
Copy link

With the triton-inference-server/common#94 in our formatter, we are running the formatter on all Triton repos. If you would like to use the formatting tool in this repo, feel free to approve/merge this PR.

@szalpal szalpal assigned szalpal and unassigned klecki Jun 23, 2023
@szalpal
Copy link
Member

szalpal commented Jun 23, 2023

@dyastremsky , thank you for the contribution.

In dali_backend repo there's already a lint enabled (https://github.com/triton-inference-server/dali_backend/blob/main/cmake/lint.cmake). I'll run the CI with this PR to see how those comply and we'll decide then.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8728848]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8728848]: BUILD PASSED

@the-david-oy
Copy link
Author

the-david-oy commented Jun 23, 2023

@dyastremsky , thank you for the contribution.

In dali_backend repo there's already a lint enabled (https://github.com/triton-inference-server/dali_backend/blob/main/cmake/lint.cmake). I'll run the CI with this PR to see how those comply and we'll decide then.

In that case, feel free to close this PR at your discretion if preferred. For context, the formatting script used is here.

@the-david-oy
Copy link
Author

@szalpal As a note, Triton is rolling out pre-commit hooks across our repos to automatically format instead . If you have interest in that, I'm happy to open a pull request for you or feel free to create one. You can see what it looks like here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants