[Backend] Fix function attributes after tensor descriptor fallback #8406
+92
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tensor descriptor rewriting pass uses 1-to-n type conversion, which will expand a tensordesc argument into multiple new pointer and int arguments. However, the upstream function conversion in mlir doesn't remap the attributes to the corresponding new argument index, which means we may make incorrect assumptions about arguments and miscompile.
ThomasRaoux
approved these changes
Oct 9, 2025
|
In this case the function in question is the kernel itself. |
I see, I didn't realize we are changing the kernel signature. That means we expect matching changes in the dispatch code? |
yangshuxin
pushed a commit
to yangshuxin/triton
that referenced
this pull request
Oct 9, 2025
…riton-lang#8406) The tensor descriptor rewriting pass uses 1-to-n type conversion, which will expand a tensordesc argument into multiple new pointer and int arguments. However, the upstream function conversion in mlir doesn't remap the attributes to the corresponding new argument index, which means we may make incorrect assumptions about arguments and miscompile.
|
Yes this case is handled by |
Jokeren
pushed a commit
that referenced
this pull request
Oct 10, 2025
…8406) The tensor descriptor rewriting pass uses 1-to-n type conversion, which will expand a tensordesc argument into multiple new pointer and int arguments. However, the upstream function conversion in mlir doesn't remap the attributes to the corresponding new argument index, which means we may make incorrect assumptions about arguments and miscompile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tensor descriptor rewriting pass uses 1-to-n type conversion, which will expand a tensordesc argument into multiple new pointer and int arguments. However, the upstream function conversion in mlir doesn't remap the attributes to the corresponding new argument index, which means we may make incorrect assumptions about arguments and miscompile.