docs: document <hole /> component pill shape and rotation support #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive documentation for pill-shaped (oval) holes - Document that pill shape props exist but are not yet implemented - Clarify rotation is not supported for <hole /> (only <platedhole />) - Add usage examples for circular holes, mounting holes, and footprints - Document Circuit JSON output format for both circular and pill shapes - Add implementation notes for future pill shape support - Clarify difference between <hole /> and <platedhole /> components Addresses issue: tscircuit #959
|
@knileshh is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
I suggest you to look for other issues, as hole with pill shape is not yet supported. Am working on supporting it, here's the pr if you want to see tscircuit/circuit-to-svg#376
|
Yes, @MustafaMulla29 I noticed that, I just thought maybe no description was provided. I should try to make a PR with updating the docs with whatever is available. |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documents the
<hole />component with pill shape and rotation support as requested in tscircuit/core#959.Changes
<hole />(only for<platedhole />)<hole />and<platedhole />componentsRelated Issue
Fixes scircuit/core#959