Deno should use the node lib rather than web #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just hit this exact same problem. I came all the way back around and realized that line was incorrect. Great catch. Changing this locally fixed everything. |
|
@penberg anything additional you need prior to merging this one? I'm happy to throw in whatever needs to be done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Deno export in package.json to use the Node.js implementation instead of the web implementation.
Deno's runtime environment more closely aligns with Node.js APIs for this particular library. While Deno typically uses web-standard APIs, our testing revealed that the Node.js implementation provides better compatibility and performance for Deno users in this specific case.
This should give improved compatibility for Deno users, and fix issues where file system access is not available.