docs: fix and add jsdocs to promise.js for tsc inference #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that many of the types in the tsc-generated
promise.d.ts
definitions were either missing or incorrect. This attempts to address some of those issues through updating JSDocs. In particular, correcting the Database constructor to type the parameter as NativeDb allows tsc to correctly infer more method return types.Here is
promise.d.ts
after a local run of tsc with these changes applied: