Standardize focus borders #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardize focus border behavior across all three screens to use Textual's default tab cycling and theme accent color. Changes: - Remove custom tab binding in Phase 3, use Textual's default tab cycling - Replace hardcoded blue focus borders with theme $accent color - Ensure all focusable widgets follow consistent pattern: - Unfocused: solid white border - Focused: heavy accent border Phase 1 (Block Selection): - BlockDetailPanel: Use theme accent color instead of blue Phase 2 (Content Editing): - Original/Suggested panels: Change from accent to white (unfocused state) - ContentEditor: Use theme accent color instead of blue on focus Phase 3 (Integration Review): - Add focus styling to journal preview (top panel) - Add focus styling to decision list - TargetPagePreview already uses accent color Tab cycling now works consistently across all three focusable widgets on Phase 3 (journal preview, decision list, target preview) using Textual's built-in behavior with shift+tab support. Updated snapshots (16 files): - Phase 2 snapshots (6 files): reflect new border colors - TargetPagePreview snapshots (10 files): blue → accent color change Assisted-by: Claude Code
When Phase 3 screen mounts, automatically focus the decision list (integration points) so users can immediately navigate decisions without needing to press Tab first. This provides a more intuitive UX by placing focus on the primary interactive element of the screen. Assisted-by: Claude Code
Fix inconsistent border behavior in StatusInfoPanel where it started with a thin orange border, then changed to thick orange when focused, and thin white when unfocused. Now follows the standard pattern: - Unfocused: solid white border - Focused: heavy accent border (via :focus-within CSS) Changes: - Update DEFAULT_CSS: border from 'solid $accent' to 'solid white' - Add :focus-within CSS rule for accent border on focus - Remove programmatic on_focus/on_blur handlers (CSS handles it) Updated 5 Phase 1 snapshots to reflect new border colors. Assisted-by: Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 84.86% 85.10% +0.24%
==========================================
Files 48 48
Lines 5087 5082 -5
==========================================
+ Hits 4317 4325 +8
+ Misses 770 757 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.