Skip to content

Conversation

prastoin
Copy link
Contributor

@prastoin prastoin commented Jul 23, 2025

Related to #13357
Ci run on a previous main version, forcing the rebase would have detect the regression

@prastoin prastoin marked this pull request as ready for review July 23, 2025 10:06
@thomtrp thomtrp enabled auto-merge (squash) July 23, 2025 10:07
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR refactors a single file to improve code consistency by replacing a service method call with a direct utility function import. The change updates packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/cron/jobs/clean-workflow-runs.cron.job.ts to use the standalone getWorkspaceSchemaName utility function instead of calling this.workspaceDataSourceService.getSchemaName().

The modification involves:

  • Adding an import for getWorkspaceSchemaName from the workspace-datasource utils
  • Replacing the service method call this.workspaceDataSourceService.getSchemaName(activeWorkspace.id) with the direct utility function call getWorkspaceSchemaName(activeWorkspace.id)

This change aligns with the codebase's existing pattern where the WorkspaceDataSourceService itself uses this same utility function internally. By eliminating the service method wrapper, the code reduces unnecessary indirection and coupling while maintaining identical functionality. The change follows the project's architectural principle of using utility functions for common operations like schema name generation.

Confidence score: 5/5

  • This is an extremely safe refactoring that simply removes a layer of indirection without changing functionality
  • The change follows established patterns in the codebase and aligns with custom rules about using utility functions
  • No files require additional attention as this is a straightforward utility function replacement

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Jul 23, 2025

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:11881

This environment will automatically shut down when the PR is closed or after 5 hours.

@FelixMalfait FelixMalfait disabled auto-merge July 23, 2025 11:17
@FelixMalfait FelixMalfait merged commit 5ac5e26 into main Jul 23, 2025
36 checks passed
@FelixMalfait FelixMalfait deleted the fix-main-typecheck branch July 23, 2025 11:17
prastoin added a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants