Skip to content

Conversation

Andrew15-5
Copy link
Contributor

@Andrew15-5 Andrew15-5 commented Oct 10, 2025

I am submitting

  • a new package
  • an update for a package

Description: I'm excited to submit a major update to the template, fixing and improving way too many things to mention (easier to look at the commit history). Well, let's just say that it got a hell of a lot smarter!

https://github.com/pammacdotnet/IJIMAI

  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

P.S. Yes, I'm authorized by Alberto to publish new versions of the IJIMAI template. (I'm also a collaborator and a full co-author of the repository/package.)

@typst-package-check typst-package-check bot added the update A package update. label Oct 10, 2025
@typst-package-check
Copy link

@pammacdotnet You released ijimai:0.0.4, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged.

@Andrew15-5 Andrew15-5 marked this pull request as draft October 10, 2025 15:47
@elegaanz elegaanz self-assigned this Oct 13, 2025
@elegaanz
Copy link
Member

Any reason this PR was marked as draft?

@Andrew15-5
Copy link
Contributor Author

Yes. I need a little more time to finish the documentation. It's almost complete. I just got home. So maybe an hour or less? But it's otherwise basically ready.

I opened it in hopes that I can submit a partially documented but fully usable version, and update once more with full documentation. But no PRs were reviewed that day, so I drafted it since might as well push an all-round version.

@elegaanz
Copy link
Member

Okay no problem, no need to rush it, take all the time you need to complete the docs.

@Andrew15-5
Copy link
Contributor Author

Andrew15-5 commented Oct 13, 2025

Well, the only reason to rush it, is that the reviews only happen during a limited period of time. And I really need it to be merged today. So yeah. Making final touches now.

@Andrew15-5 Andrew15-5 marked this pull request as ready for review October 13, 2025 11:05
@typst-package-check
Copy link

@pammacdotnet You released ijimai:0.0.4, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged.

@Andrew15-5
Copy link
Contributor Author

Andrew15-5 commented Oct 13, 2025

@elegaanz, ready! You can take a quick look at the readme in https://github.com/pammacdotnet/IJIMAI. It can be still improved, but it's more than enough for now. I've actually caught a lot of issues during several proofreading in the last hour or so. Pretty sure I've still missed something, which is how normally it goes. But it's not that important anyway.

P.S. Would be nice if the bot didn't repeat itself.

@Andrew15-5
Copy link
Contributor Author

I hope it's not too late today, is it?

@elegaanz
Copy link
Member

It's not, I was just having my lunch break, I'll review it now.

@Andrew15-5
Copy link
Contributor Author

Oh, ok then. Sorry for rushing you.

@elegaanz
Copy link
Member

After a quick look it seems to be good. If you find a bug you can of course submit a patch version.

@elegaanz elegaanz merged commit 8800519 into typst:main Oct 13, 2025
2 of 3 checks passed
@Andrew15-5 Andrew15-5 deleted the ijimai-1.0.0 branch October 13, 2025 12:50
@pammacdotnet
Copy link
Contributor

Thanks a lot for your time @elegaanz… and thanks @Andrew15-5 for his valuable help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update A package update.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants