-
Notifications
You must be signed in to change notification settings - Fork 730
ijimai:1.0.0 #3221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ijimai:1.0.0 #3221
Conversation
@pammacdotnet You released ijimai:0.0.4, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
Any reason this PR was marked as draft? |
Yes. I need a little more time to finish the documentation. It's almost complete. I just got home. So maybe an hour or less? But it's otherwise basically ready. I opened it in hopes that I can submit a partially documented but fully usable version, and update once more with full documentation. But no PRs were reviewed that day, so I drafted it since might as well push an all-round version. |
Okay no problem, no need to rush it, take all the time you need to complete the docs. |
Well, the only reason to rush it, is that the reviews only happen during a limited period of time. And I really need it to be merged today. So yeah. Making final touches now. |
4dbfeb9
to
5eecf42
Compare
@pammacdotnet You released ijimai:0.0.4, so you probably want to have a look at this pull request. If you want this update to be merged, please leave a comment stating so. Without your permission, the pull request will not be merged. |
@elegaanz, ready! You can take a quick look at the readme in https://github.com/pammacdotnet/IJIMAI. It can be still improved, but it's more than enough for now. I've actually caught a lot of issues during several proofreading in the last hour or so. Pretty sure I've still missed something, which is how normally it goes. But it's not that important anyway. P.S. Would be nice if the bot didn't repeat itself. |
I hope it's not too late today, is it? |
It's not, I was just having my lunch break, I'll review it now. |
Oh, ok then. Sorry for rushing you. |
After a quick look it seems to be good. If you find a bug you can of course submit a patch version. |
Thanks a lot for your time @elegaanz… and thanks @Andrew15-5 for his valuable help. |
I am submitting
Description: I'm excited to submit a major update to the template, fixing and improving way too many things to mention (easier to look at the commit history). Well, let's just say that it got a hell of a lot smarter!
https://github.com/pammacdotnet/IJIMAI
P.S. Yes, I'm authorized by Alberto to publish new versions of the IJIMAI template. (I'm also a collaborator and a full co-author of the repository/package.)