Skip to content

remove unnecessary connection in project_openldap utils.py #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
+0 −4
Merged

remove unnecessary connection in project_openldap utils.py #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions coldfront/plugins/project_openldap/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ def remove_dn_from_openldap(dn, write=True):

try:
conn.delete(dn)
conn.unbind()
conn = openldap_connection(server, PROJECT_OPENLDAP_BIND_USER, PROJECT_OPENLDAP_BIND_PASSWORD)
except Exception as exc_log:
logger.info(exc_log)
finally:
Expand All @@ -191,7 +189,6 @@ def update_posixgroup_description_in_openldap(dn, openldap_description, write=Tr

try:
conn.modify(dn, {"description": [(MODIFY_REPLACE, [openldap_description])]})
conn.unbind()
except Exception as exc_log:
logger.info(exc_log)
finally:
Expand All @@ -211,7 +208,6 @@ def move_dn_in_openldap(current_dn, relative_dn, destination_ou, write=True):

try:
conn.modify_dn(current_dn, relative_dn, new_superior=destination_ou)
conn.unbind()
except Exception as exc_log:
logger.info(exc_log)
finally:
Expand Down