Add Description to Media Group #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brainwo, Thanks for the PR. If I run the tests, I find that several fail. If I revert the change you made to the helper class back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by YouTube: https://www.youtube.com/feeds/videos.xml?channel_id=UClS6E2qjk2DkxRCZ1xU0VXA
Added test as well.
Alongside with this PR, I also change the helper
findElementOrNullfunction. Originally it would search through all the element recursively, which doesn't work whenmedia:descriptioncan be both child ofentryandmedia:group. This new change should only find the first direct descendant as how it supposed to.