Skip to content

Conversation

@Craftplacer
Copy link
Collaborator

@Craftplacer Craftplacer commented Nov 4, 2024

Resolves #7

@Craftplacer Craftplacer requested a review from Jupi007 November 4, 2024 10:57
Copy link
Collaborator

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove avoid_print: ignore in analysis_options.yaml.

@Feichtmeier
Copy link
Member

just a question: does this package always print or only if(kDebugMode) ?

@Jupi007
Copy link
Collaborator

Jupi007 commented Nov 4, 2024

@Feichtmeier The goal is to log messages, then leave the app developer the responsibility to print them (see the example app).

@Jupi007 Jupi007 merged commit 03edaef into ubuntu-flutter-community:main Nov 6, 2024
3 checks passed
@Jupi007
Copy link
Collaborator

Jupi007 commented Nov 6, 2024

Thanks @Craftplacer
I'll push my isolate patch tomorrow.

@Craftplacer Craftplacer deleted the logging branch November 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use proper logging framework

3 participants