feat(compiler): add span to inconsistent constraints #117
Conversation
|
|
||
| state.constraint_span_map.insert( | ||
| constraint, | ||
| Span { |
There was a problem hiding this comment.
Use self.span instead of manually constructing the span.
core/compiler/src/compile.rs
Outdated
| { | ||
| state.fallback_constraints_used.push(constraint.clone()); | ||
| state.solver.constrain_eq0(constraint); | ||
| state.solver.constrain_eq0(constraint, None); |
There was a problem hiding this comment.
You might still need to store the span in the FallbackConstraint struct if you aren't able to get the span otherwise here. We want to be able to debug fallback constraints as well.
core/compiler/src/compile.rs
Outdated
| }); | ||
| } | ||
|
|
||
| let inconsistent_errors = { |
There was a problem hiding this comment.
It shouldn't be necessary to collect everything into a new Vec, what error were you getting before? I know you mentioned it earlier, but didn't realize it should have been fixable.
core/compiler/src/compile.rs
Outdated
| }); | ||
| } else { | ||
| state.solver.constrain_eq0(expr); | ||
| state.solver.constrain_eq0(expr, None); |
core/compiler/src/solver.rs
Outdated
| /// Constrains the value of `expr` to 0. | ||
| /// TODO: Check if added constraints conflict with existing solution. | ||
| pub fn constrain_eq0(&mut self, expr: LinearExpr) -> ConstraintId { | ||
| pub fn constrain_eq0(&mut self, expr: LinearExpr, span: Option<Span>) -> ConstraintId { |
There was a problem hiding this comment.
Sorry to make you change this back, but I realized that it is probably a bad abstraction to have the solver know about Spans. The reason we made you change it is that it didn't seem elegant to put the Span in multiple structs, but it would be better for the ExecPass to simply have a ConstraintId to Span map.
CONnor9029
force-pushed
the
compiler_debug_info
branch
from
1d7781b to
a9dd2cb
Compare
No description provided.