Respect height attributes when provided #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'd love to see this one reviewed too if possible. I can't review myself as the starting point for this PR came from my code changes! |
|
@AndyBoot, @mistyn8, @warrenbuckley is there any chance you could review this PR soon? We found a workaround to use it in our code, but we'd find it really useful if it was part of the package. There's more detail in #66 (but we abandoned #66 and continued here). Thanks! |
|
Code reads fine and thanks again for your contribution !! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up from where @kahlan88 had got to with regards to respecting height attributes when using a
media-item.The original pull request and discussion for reference is here: #66