Block Catalogue: Localizes block-type name/description before render (closes #20890) #20904
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the Block Catalogue's search/filter functionality didn't work correctly with localized block-type names and descriptions. The fix moves the localization from render time (in the template) to data processing time (when block types are first observed and grouped).
- Localizes block-type name and description earlier in the data flow, during the reduce operation that builds the lookup table
- Removes redundant localization calls from the render template since data is now pre-localized
- Enables search/filter to query against localized strings instead of localization keys
iOvergaard
approved these changes
Nov 20, 2025
iOvergaard
deleted the
v17/bugfix/block-catalogue-modal-filter-localization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20890
The filtering used on the Block Catalogue queries against the block-type data, meaning when localizations are used for a block-type's name and description, these are localized as render time (in the block-card display), and not in the data (source).
This PR moves the localization to when the block-types are first observed and processed (into groups). This means that the Block Catalogue filtering with query against the localized strings.