Tiptap RTE: Adds a umbIgnorePasswordManagers Lit directive (closes #20897)
#20905
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that password manager / browser extensions can ignore the RTE contents.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Lit directive to prevent password manager browser extensions from interfering with the Tiptap Rich Text Editor (RTE). The directive applies ignore attributes for major password managers (1Password, Bitwarden, Dashlane, and LastPass) to the RTE editor element.
Key changes:
- Creates a new
umbIgnorePasswordManagersLit directive that applies password manager ignore attributes - Applies the directive to the Tiptap RTE editor div element
- Exports the new directive from the lit-element directives index
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ignore-password-managers.lit-directive.ts | Implements the new Lit directive with attributes for 1Password, Bitwarden, Dashlane, and LastPass |
| index.ts | Exports the new directive and alphabetizes the export list |
| input-tiptap.element.ts | Imports and applies the directive to the RTE editor element |
...UI.Client/src/packages/core/lit-element/directives/ignore-password-managers.lit-directive.ts
Show resolved
Hide resolved
...UI.Client/src/packages/core/lit-element/directives/ignore-password-managers.lit-directive.ts
Outdated
Show resolved
Hide resolved
...UI.Client/src/packages/core/lit-element/directives/ignore-password-managers.lit-directive.ts
Show resolved
Hide resolved
iOvergaard
added
the
preview/backoffice
- Adds JSDocs - changed to use `Directive` - constructor checks if the directive is being used on an element - return `noChange` from update
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20905.westeurope.6.azurestaticapps.net |
Contributor
|
I am closing this PR because the attributes need to go directly on the native input field, which need to be handled in the UI Library. See additional testing notes here: #20897 (comment) |
madsrasmussen
removed
type/bug
area/frontend
preview/backoffice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20897
Adds a
umbIgnorePasswordManagersLit directive, so that password manager / browser extensions can ignore the RTE contents.The idea of this Lit directive is to group the ignore attributes for each of the major password manager browser extensions into a single directive, similar to how it was in v8+(see #4153). Initially we have ignore attributes for 1Password, Bitwarden, Dashlane and LastPass.