-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Examine Management: Allow selection of all available fields in Examine search results, and fix layout issue when not all records have all fields (closes #20878 and #20879) #20909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and fix layout issue when not all records have all fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes two issues in the Examine Management search results feature: enabling selection of all available fields across the entire result set (not just fields present in all records), and ensuring proper table layout when selected fields are missing from some records.
Key Changes:
- Refactored
_updateFieldFilter()to collect all unique fields across all search results and preserve user's field selection state - Updated
renderBodyCells()to render empty table cells for missing fields, ensuring consistent table layout
...rc/packages/core/search/examine-management-dashboard/views/section-view-examine-searchers.ts
Outdated
Show resolved
Hide resolved
...rc/packages/core/search/examine-management-dashboard/views/section-view-examine-searchers.ts
Show resolved
Hide resolved
...rc/packages/core/search/examine-management-dashboard/views/section-view-examine-searchers.ts
Outdated
Show resolved
Hide resolved
|
@AndyButland it sounds like you fixed this issue too? #20879 😎🙌 |
|
Thanks @bjarnef - good to know, I'll associate that one with this PR too. |
|
Two for the price of one 😅🙌 |
leekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out, works as described. 🚀
Prerequisites
Fixes: #20878 and #20879
Description
This PR addresses two issues found on the Examine Management search results feature:
Testing
Create a document type with some properties and create a few content items using that type.
Add a new property and populate it on only a subset of content items.
Verify that in the Examine searcher you can select all fields for view.
Verify the layout looks as expected when the field is available only some of the records.
To find all content for a given document type, use
__NodeTypeAlias:{docTypeAlias}as the search term, e.g.__NodeTypeAlias:person.