Skip to content

Conversation

@AndyButland
Copy link
Contributor

@AndyButland AndyButland commented Nov 20, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Fixes: #20878 and #20879

Description

This PR addresses two issues found on the Examine Management search results feature:

  • You previously couldn't select all fields that were available in the record set. If a field was available in some records but not others, it could be omitted from the fields available to select.
  • When rendering the records, if a field selected for display didn't exist for some records, no cell would be written, leading to an odd layout where other records did have the field, with missing cell borders.

Testing

Create a document type with some properties and create a few content items using that type.
Add a new property and populate it on only a subset of content items.
Verify that in the Examine searcher you can select all fields for view.
Verify the layout looks as expected when the field is available only some of the records.

To find all content for a given document type, use __NodeTypeAlias:{docTypeAlias} as the search term, e.g. __NodeTypeAlias:person.

…and fix layout issue when not all records have all fields.
Copilot AI review requested due to automatic review settings November 20, 2025 12:30
@AndyButland AndyButland changed the title Examine Management: Allowed selection of all available fields in Examine search results, and fix layout issue when not all records have all fields Examine Management: Allowed selection of all available fields in Examine search results, and fix layout issue when not all records have all fields (closes #20878) Nov 20, 2025
@AndyButland AndyButland changed the title Examine Management: Allowed selection of all available fields in Examine search results, and fix layout issue when not all records have all fields (closes #20878) Examine Management: Allow selection of all available fields in Examine search results, and fix layout issue when not all records have all fields (closes #20878) Nov 20, 2025
Copilot finished reviewing on behalf of AndyButland November 20, 2025 12:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes two issues in the Examine Management search results feature: enabling selection of all available fields across the entire result set (not just fields present in all records), and ensuring proper table layout when selected fields are missing from some records.

Key Changes:

  • Refactored _updateFieldFilter() to collect all unique fields across all search results and preserve user's field selection state
  • Updated renderBodyCells() to render empty table cells for missing fields, ensuring consistent table layout

@bjarnef
Copy link
Contributor

bjarnef commented Nov 20, 2025

@AndyButland it sounds like you fixed this issue too? #20879 😎🙌

@AndyButland
Copy link
Contributor Author

Thanks @bjarnef - good to know, I'll associate that one with this PR too.

@AndyButland AndyButland changed the title Examine Management: Allow selection of all available fields in Examine search results, and fix layout issue when not all records have all fields (closes #20878) Examine Management: Allow selection of all available fields in Examine search results, and fix layout issue when not all records have all fields (closes #20878 and #20879) Nov 21, 2025
@bjarnef
Copy link
Contributor

bjarnef commented Nov 21, 2025

Two for the price of one 😅🙌

@leekelleher leekelleher self-requested a review November 24, 2025 17:20
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out, works as described. 🚀

@leekelleher leekelleher merged commit cf265e2 into main Nov 24, 2025
28 checks passed
@leekelleher leekelleher deleted the v17/bugfix/allow-select-all-examine-fields branch November 24, 2025 17:57
@leekelleher leekelleher linked an issue Nov 24, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Border missing in cells for custom fields Examine dashboard doesn't allow to toggle all available fields

4 participants