Multi URL Picker: change validation for url and anchor/querystring #20920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7/fix-bug/multi-url-picker-validation
leekelleher
requested changes
Nov 24, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
@NguyenThuyLan I've been testing this out, it's heading in the right direction, but I feel that the (red) "invalid" prompts that appear as soon as the user selects the Manual option is quite alarming.
Is it possible to have the validation trigger when the modal is about to be submitted?
…7/fix-bug/multi-url-picker-validation
Contributor
Author
|
Thanks @leekelleher , I updated my PR |
leekelleher
approved these changes
Nov 25, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Re-tested, looking good, great work! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes for the issue #19998
To avoid conflict with the issue #17411,
I added validation for both
Sourcefield andAnchor and queryStringfield. If both of these fields are blank, the link cannot be added, if either of the two fields is entered, the link can still be added.