-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Log Viewer: Adds localization in the Backoffice UI + cleans up unused keys #20923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20923.westeurope.6.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request modernizes the log viewer localization by replacing hardcoded strings with proper localization keys and introducing parameterized functions for dynamic polling intervals. The changes remove redundant translation keys across all 15 supported languages while adding comprehensive new UI strings to English and Danish translations.
Key Changes:
- Replaces all hardcoded UI strings in log viewer components with localized terms
- Introduces parameterized
pollingIntervalandpollingActivefunctions for dynamic polling display - Removes 11-17 unused/redundant translation keys from each language file
- Adds 29 new translation keys to English and Danish for enhanced log viewer UI
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| log-viewer-search-input.element.ts | Localizes search input labels, placeholders, and button text |
| log-viewer-search-input-modal.element.ts | Localizes save search dialog with proper labels and buttons |
| log-viewer-polling-button.element.ts | Implements dynamic polling interval display using parameterized functions |
| log-viewer-messages-list.element.ts | Localizes table headers, empty states, and loading messages |
| log-viewer-message.element.ts | Converts search menu to use localized labels and converts static array to method |
| log-viewer-log-level-filter-menu.element.ts | Localizes log level filter options and labels |
| log-overview-view.element.ts | Localizes overview section headings |
| log-viewer-saved-searches-overview.element.ts | Localizes saved searches section and "All logs" label |
| log-viewer-message-templates-overview.element.ts | Localizes message templates heading and count display |
| log-viewer-log-types-chart.element.ts | Localizes chart heading and description |
| log-viewer-too-many-logs-warning.element.ts | Localizes warning messages and changes base class to UmbLitElement |
| log-viewer-date-range-selector.element.ts | Localizes date range labels |
| en.ts | Removes 11 unused keys and adds 29 new log viewer UI strings |
| da.ts | Removes 16 unused keys, adds 29 new strings, and fixes whitespace |
| vi.ts | Removes 16 unused keys and adds polling interval functions |
| tr.ts | Removes 7 unused keys (missing polling functions) |
| pt.ts | Removes 16 unused keys and adds polling interval functions |
| nl.ts | Removes 16 unused keys and adds polling interval functions |
| it.ts | Removes 16 unused keys and adds polling interval functions |
| hr.ts | Removes 16 unused keys and adds polling interval functions |
| fr.ts | Removes 7 unused keys (missing polling functions) |
| cy.ts | Removes 16 unused keys and adds polling interval functions |
| cs.ts | Removes 7 unused keys (missing polling functions) |
| bs.ts | Removes 16 unused keys and adds polling interval functions |
| ar.ts | Removes 16 unused keys and adds polling interval functions |
leekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out. Code-wise, I'm happy with this. But shouldn't we consider removing localization keys as a breaking-change?
|
@leekelleher we can certainly keep them in there. I just wondered because they have not been used in the last 3 majors, so how does one actually "deprecate" a language key? |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20923.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20923.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20923.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20923.westeurope.6.azurestaticapps.net |
This pull request updates the log viewer translations across multiple languages to improve consistency, reduce duplication, and support dynamic polling intervals. It removes several redundant or unused log-related strings and introduces parameterized functions for polling intervals in all supported languages. Additionally, the English and Danish translations receive several new log viewer UI strings for enhanced user experience.
Translation cleanup and consistency:
filterSearch,totalItems,exception,properties, and various "find logs with..." and "open" entries from all affected language files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Polling interval improvements:
pollingIntervalandpollingActive) in all languages, allowing dynamic display of polling intervals. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Enhancements to English and Danish translations:
en.tsandda.ts. [1] [2]Streamlining and modernization:
Improved user experience: