Media Picker: Present root nodes for users with more than one media root node assigned (closes #20967) #20993
+32
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia root node assigned.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #20967 where users with multiple media root nodes (assigned either directly or through user group memberships) could not see any nodes in the media picker. Previously, the GetPagedChildren endpoint returned an empty result when queried at root level for users with custom start nodes; it now correctly returns the user's start nodes as entities.
Key Changes
- Modified the root-level entity retrieval logic to fetch and return actual entities for users with multiple start nodes instead of returning an empty collection
- Refactored duplicate entity mapping logic into a reusable local function
MapEntityBasic, which also fixed a bug where culture was set twice in the mapping context
| if (id == Constants.System.Root && startNodeIds.Length > 0 && | ||
| startNodeIds.Contains(Constants.System.Root) == false && !ignoreUserStartNodes) | ||
| startNodeIds.Contains(Constants.System.Root) == false && | ||
| ignoreUserStartNodes == false) |
There was a problem hiding this comment.
The expression 'A == false' can be simplified to '!A'.
Suggested change
| ignoreUserStartNodes == false) | |
| !ignoreUserStartNodes) |
AndyButland
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #20967
Description
This PR fixes an issue with the following setup:
It's reported as a regression but:
Testing
Follow steps in description above and verify the presentation and selection of items in the media picker.