uui-textarea, uui-input: new max length message validation (closes Umbraco-CMS/issues/20710) #1227
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1227.westeurope.azurestaticapps.net |
| * @default | ||
| */ | ||
| @property({ attribute: 'maxlength-message' }) | ||
| maxlengthMessage: string | ((max: number, current: number) => string) = ( |
There was a problem hiding this comment.
Changing this from current to exceeded is a breaking change.
We must remember we are not the only ones using the UI Library. So there may be someone who already uses this and parses in those values. So we need to have the logiv locally.
I would suggest to resolve in this way: Maximum ${max} characters, ${current-max} too many
There was a problem hiding this comment.
Yes, I didn't think of it. I updated this issue
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1227.westeurope.azurestaticapps.net |
Description
This PR fixes for umbraco/Umbraco-CMS#20710
Types of changes
How to test?
New message when exceeded will be like this:
"Maximum
{max}characters,{exceeded}too many."