-
Notifications
You must be signed in to change notification settings - Fork 813
Update adding-a-workflowtype.md #7261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added information on adding settings to workflows
|
Thanks for the PR, @jonathoncove3 πWe will review it asap. |
|
Looks like we already have documentation on adding settings to any supported type (e.g. field types, data sources, export types, prevalue sources, recordset actions and workflows) here: https://docs.umbraco.com/umbraco-forms/13.latest/developer/extending/adding-a-type#adding-settings-to-a-type. And all built-in setting views are listed here: https://docs.umbraco.com/umbraco-forms/13.latest/developer/extending/adding-a-type/setting-types. However, the field type page provides more in-depth documentation about adding translations and the different configuration properties (like So I'd recommend moving most of the setting documentation from the field type page to the 'Setting Types' page and adding a paragraph to all supported provider types with a minimal description/example and link to the generic setting types page... |
ronaldbarendse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that v14+ can benefit from the same improvements, but uses property editor UI aliases for the setting views (instead of the AngularJS file paths).
|
@jonathoncove3 Since itβs been a while, just checking in to see if youβve seen @ronaldbarendse message on this PR and if you have any thoughts or updates. |
|
Hi @eshanrnh , I agree on @ronaldbarendse 's comments, it would be more useful to mention the ability and reference to a more detailed area. Is that a me task as the PR author, or can someone else pick that up? |
|
@jonathoncove3 It would be great if you could do it. If not, I'll add it to my backlog to take care of it :) |
Added information on adding settings to workflows
π Description
π Related Issues (if applicable)
β Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
Deadline (if relevant)
π Helpful Resources