-
Notifications
You must be signed in to change notification settings - Fork 812
Block List and Block Grid v16 Documentation #7598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Block List and Block Grid v16 Documentation #7598
Conversation
Luuk1983
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clear and with the updated images, it's up to date. Just check if the very complicated long urls of the images are really needed, I think it can be way simpler. Also I would like some extra information about headless environments.
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
| You will see the configuration options for adding Block Types to the Grid as shown below. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put this remark here, but that applies to all images. To me, tthis url structure seems really weird. Isn't it just ./images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be "./images" if you want to reference images in the same folder - which in this case you could do, as it's a v16 doc referencing a v16 image. However, it is typical in the docs to use these longer pathnames which ensure that docs work correctly even if copied/carried into another version. For example, when this doc gets copied into v17, the longer path will still work and point to the correct imagery.
|
|
||
| You will also see the following additional configuration options. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image does not render, check the path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a quirk of how the gitbook preview works - none of the images I see in gitbook are updated, and the ones that don't render are "new" ones which don't have an equivalent in the existing doc.
| Advanced properties are also available for each Block, as shown below. | ||
|
|
||
| * **Custom view** - Overwrites the AngularJS view for the block presentation in the Content editor. Use this view to make a more visual presentation of the Block or make your own editing experience by adding your own AngularJS controller to the view. | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image does not render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a quirk of how the gitbook preview works - none of the images I see in gitbook are updated, and the ones that don't render are "new" ones which don't have an equivalent in the existing doc.
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Show resolved
Hide resolved
|  | ||
|
|
||
| _This can also be tested via Postman as well if preffered._ | ||
| _This can also be tested via Postman as well if preferred._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really would like a section or chapter about using Block Grid in a headless environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One has been added! If you're happy to take another look?
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-list-editor.md
Show resolved
Hide resolved
This is no longer present in v16
To match how they now display in the backoffice
This wording has changed.
cf39ee9 to
13ed6c8
Compare
Per PR feedback
Per PR feedback
Per PR feedback request
π Description
Updates to existing pages for Block List Editor and Block Grid Editor, which document how to configure and use these property editors.
π Related Issues (if applicable)
N/A
β Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
v16 and v17
Deadline (if relevant)
N/A
π Helpful Resources