[UNDERTOW-2575] Add flush before socket close on write timeout #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
added
the
under verification
|
This PR looks correct to me. Still, given the complexity of this issue, I'll run the reproducer and verify the points raised by @baranowb in the Jira so we can be 100% certain this is the way to go. |
|
@baranowb now that I'm almost done with the backports, I'll start looking at the PRs, including yours, you should hear back from me on this until Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2575
main PR: #1747
2.3.x PR: #1748
Related issues: https://issues.redhat.com/browse/UNDERTOW-2545
2575 is actually duplicate of 2545