[UNDERTOW-2537] Implement bit shift window rate limiter and limiter h… #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baranowb
added
enhancement
baranowb
commented
Sep 3, 2025
| } | ||
| } | ||
|
|
||
| private String getIPAddress(final HttpServerExchange exchange, final boolean warn) { |
There was a problem hiding this comment.
This is not ideal, this code is repeated in Handler class to get log details as well.
baranowb
commented
Sep 3, 2025
| final String current = String.valueOf(currentPrefix); | ||
| final String next = String.valueOf(currentPrefix + 1); | ||
|
|
||
| ConcurrentHashMap.KeySetView<String, AtomicInteger> keys = requestCounter.keySet(); |
There was a problem hiding this comment.
String could be turned into Long with high bits holding IP in pure form and lower working as in this case. But its harder to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…andler
Issue: https://issues.redhat.com/browse/UNDERTOW-2537
This needs review. Initially I was going to have Long as key and use bit shifts to encode there everything, but:
If needs be I can switch it to above without problem. It follows similar concept of common sliding window with low accuracy as apache does in its impl. However interface should allow to implement different stategies as well relatively easily .
TestCase is a bit of PITa as to test different aspects it has to be at least 60s( might be less) so it chugs some time on CI...