Skip to content

[UNDERTOW-2494]-Create a default constant for UndertowOptions.QUEUED_FRAMES_HIGH_WATER_MARK #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2494]-Create a default constant for UndertowOptions.QUEUED_FRAMES_HIGH_WATER_MARK #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/src/main/java/io/undertow/UndertowOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,11 +402,16 @@ public class UndertowOptions {
*/
public static final Option<String> ENDPOINT_IDENTIFICATION_ALGORITHM = Option.simple(UndertowOptions.class, "ENDPOINT_IDENTIFICATION_ALGORITHM", String.class);

/**
* Default value of {@link #QUEUED_FRAMES_HIGH_WATER_MARK} option.
*/
public static final int DEFAULT_QUEUED_FRAMES_HIGH_WATER_MARK = 50;

/**
* The maximum numbers of frames that can be queued before reads are suspended. Once this number is hit then reads will not be resumed until {@link #QUEUED_FRAMES_LOW_WATER_MARK}
* is hit.
*
* Defaults to 50
* <p>
* Defaults to {@link #DEFAULT_QUEUED_FRAMES_HIGH_WATER_MARK}
*/
public static final Option<Integer> QUEUED_FRAMES_HIGH_WATER_MARK = Option.simple(UndertowOptions.class, "QUEUED_FRAMES_HIGH_WATER_MARK", Integer.class);

Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/io/undertow/server/protocol/framed/AbstractFramedChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ protected AbstractFramedChannel(final StreamConnection connectedStreamChannel, B
FrameCloseListener closeListener = new FrameCloseListener();
connectedStreamChannel.getSinkChannel().getCloseSetter().set(closeListener);
connectedStreamChannel.getSourceChannel().getCloseSetter().set(closeListener);
this.queuedFrameHighWaterMark = settings.get(UndertowOptions.QUEUED_FRAMES_HIGH_WATER_MARK, 50);
this.queuedFrameHighWaterMark = settings.get(UndertowOptions.QUEUED_FRAMES_HIGH_WATER_MARK, UndertowOptions.DEFAULT_QUEUED_FRAMES_HIGH_WATER_MARK);
this.queuedFrameLowWaterMark = settings.get(UndertowOptions.QUEUED_FRAMES_LOW_WATER_MARK, 10);
}

Expand Down
Loading