feat(lightclient): add CommitClientStatus message to persist client s… #4859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the unionbuild Team on Vercel. A member of the Team first needs to authorize it. |
benluelo
reviewed
Jul 20, 2025
benluelo
reviewed
Jul 20, 2025
|
also please verify your commits as per our contributing guide. |
0xumutkk
force-pushed
the
feat/lightclient-commit-status
branch
from
55a5626 to
8e70297
Compare
benluelo
requested changes
Jul 21, 2025
| ) -> RpcResult<Option<u8>> { | ||
| let status = self | ||
| .query_smart::<_, u8>( | ||
| &ibc_union_msg::query::QueryMsg::GetStatus { client_id }, |
There was a problem hiding this comment.
this is the wrong query; you need to use GetCommittedStatus
aeryz
previously approved these changes
Jul 24, 2025
benluelo
requested changes
Jul 24, 2025
| client_id: msg.client_id, | ||
| } | ||
| .key(), | ||
| &commit(status_bytes), |
There was a problem hiding this comment.
store the bytes directly, as a U256 value
| &self, | ||
| height: Height, | ||
| client_id: ClientId, | ||
| ) -> RpcResult<Option<u8>> { |
There was a problem hiding this comment.
this should return Option<Status>
| &self, | ||
| height: Height, | ||
| client_id: ClientId, | ||
| ) -> RpcResult<Option<u8>> { |
| %client_id | ||
| ) | ||
| )] | ||
| async fn query_client_status( |
There was a problem hiding this comment.
rename this to query_committed_client_status (in the evm impl as well)
benluelo
requested changes
Jul 28, 2025
| client_id: msg.client_id, | ||
| } | ||
| .key(), | ||
| &commit(U256::from(status as u32).to_le_bytes()), |
There was a problem hiding this comment.
don't store the commit, but the u256 value directly
| GetStatus { client_id: ClientId }, | ||
| #[cfg_attr(feature = "cw-orch-interface", returns(Option<H256>))] |
0xumutkk
force-pushed
the
feat/lightclient-commit-status
branch
from
5641ae7 to
b3cb34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new 'CommitClientStatus' message to explicitly commit the client's status (Active, Expired, or Frozen) into state storage as a hashed commitment using 'store_commit'.
Closes #4842