Propagate GRPCProvider basic auth credentials #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
1 issue found across 2 files • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| return map[string]string{"authorization": "Basic " + token}, nil | ||
| } | ||
|
|
||
| func (b *basicAuthCreds) RequireTransportSecurity() bool { return false } |
There was a problem hiding this comment.
PerRPC credentials declare they do NOT require transport security, allowing Basic-Auth credentials to be sent over plaintext connections. This exposes usernames and passwords whenever prov.UseSSL is false, which contradicts the usual expectation that authentication data is only transmitted over TLS. Set this to true (or make it configurable) to avoid leaking credentials.
(Based on your team's feedback about always protecting sensitive data in transit.)
Prompt for AI agents
Address the following comment on src/transports/grpc/grpc_transport.go at line 39:
<comment>PerRPC credentials declare they do NOT require transport security, allowing Basic-Auth credentials to be sent over plaintext connections. This exposes usernames and passwords whenever prov.UseSSL is false, which contradicts the usual expectation that authentication data is only transmitted over TLS. Set this to true (or make it configurable) to avoid leaking credentials.
(Based on your team's feedback about always protecting sensitive data in transit.)</comment>
<file context>
@@ -21,9 +22,22 @@ import (
. "github.com/universal-tool-calling-protocol/go-utcp/src/providers/grpc"
"github.com/universal-tool-calling-protocol/go-utcp/src/transports"
+ . "github.com/universal-tool-calling-protocol/go-utcp/src/auth"
. "github.com/universal-tool-calling-protocol/go-utcp/src/tools"
)
+type basicAuthCreds struct {
+ username string
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Propagates GRPCProvider BasicAuth to all gRPC calls using per-RPC credentials. This fixes missing Authorization headers so servers can authenticate requests.