Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions internal/sqladapter/testing/adapter.go.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package ADAPTER

import (
"database/sql"
"database/sql/driver"
"flag"
"fmt"
"log"
Expand Down Expand Up @@ -1978,3 +1979,43 @@ func TestCustomType(t *testing.T) {

assert.Equal(t, "foo: some name", string(bar.Custom.Val))
}

type brokenValuer string

func (b brokenValuer) Value() (driver.Value, error) {
panic("broken valuer")
return nil, nil
}

// See: https://github.com/upper/db/issues/508
func TestBrokenValuer(t *testing.T) {
defer func() {
r := recover()
assert.NotNil(t, r, "expecting a panic")
}()

sess := mustOpen()

value := brokenValuer("test")
q := sess.Select().From("artist").Where(db.Cond{"name": value})

q.Query()
}

func TestBrokenValuerTx(t *testing.T) {
defer func() {
r := recover()
assert.NotNil(t, r, "expecting a panic")
}()

sess := mustOpen()
tx, err := sess.NewTx(nil)
defer tx.Close()

assert.NoError(t, err)

value := brokenValuer("test")
q := tx.Select().From("artist").Where(db.Cond{"name": value})

q.Query()
}