Skip to content

Use actual ellipses. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timkelty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use actual ellipses. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TruncateInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ interface TruncateInterface
public function truncate(
$text,
$length = 100,
$ending = '...',
$ending = '…',
$exact = false,
$considerHtml = true
);
Expand Down
2 changes: 1 addition & 1 deletion src/TruncateService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public static function create()
public function truncate(
$text,
$length = 100,
$ending = '...',
$ending = '…',
$exact = false,
$considerHtml = true
) {
Expand Down
8 changes: 4 additions & 4 deletions tests/TruncateServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ public function setUp()
public function provider()
{
return array(
array('<p>Hello world!</p>', 10, '<p>Hello...</p>'),
array('<p>Hello world!</p>', 10, '<p>Hello…</p>'),
array('<p>Hello world!</p>', 30, '<p>Hello world!</p>'),
array('<p>Hello <b>World!</b> blah blah blah</p>', 20, '<p>Hello <b>World!</b>...</p>'),
array('<b>One</b><b>Two</b> <b>Three</b>', 10, '<b>One</b><b>Two</b>...'),
array('<p>Hello world! <img src="http://img.test.com/img.jpg" /></p>', 10, '<p>Hello...</p>'),
array('<p>Hello <b>World!</b> blah blah blah</p>', 20, '<p>Hello <b>World!</b>…</p>'),
array('<b>One</b><b>Two</b> <b>Three</b>', 10, '<b>One</b><b>Two</b>…'),
array('<p>Hello world! <img src="http://img.test.com/img.jpg" /></p>', 10, '<p>Hello…</p>'),
array('<p>Hello world! <img src="http://img.test.com/img.jpg" /></p>', 20, '<p>Hello world! <img src="http://img.test.com/img.jpg" /></p>'),
);
}
Expand Down