Add columns property to ActivitySprunje class #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix so you can't download a users hashed password
There was a problem hiding this comment.
Pull request overview
This PR adds a security fix to the ActivitySprunje class to prevent user password hashes from being exposed through the activities API. When activities are joined with user data, only explicitly whitelisted columns are now returned, excluding sensitive fields like password hashes.
Key Changes
- Added a
$columnsproperty to ActivitySprunje that whitelists safe columns from both the activities and users tables - Ensures password hashes and other potentially sensitive user fields are not exposed when querying activities
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
I merged it for V5 as a quick fix, but I think it doesn't fully solve it. Any other Sprunje with a left join might include the sensitive data. It's not included when the JSON is returned as this one invoke the model "hidden" part. So I think CSV should call "toArray" in the background instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix so you can't download a users hashed password