Use assertSame in tests

[hmacr]

Summary by CodeRabbit

• Tests
  • Strengthened test assertions across messaging adapter modules to enforce stricter type and value matching, ensuring more comprehensive validation of response handling and data processing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The changes involve replacing loose equality assertions with strict equality assertions across nine test files in the Messaging/Adapter directory. Specifically, assertEquals() calls are replaced with assertSame() for various comparison targets including response fields, phone numbers, status values, URLs, and other message properties. This refactor applies consistently across tests for Email, SMS, Discord, and other messaging adapter implementations. No logic, control flow, or public entity declarations are altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: replacing assertEquals with assertSame throughout the test files.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c5be45 and f92546a.

📒 Files selected for processing (9)

• tests/Messaging/Adapter/Base.php
• tests/Messaging/Adapter/Chat/DiscordTest.php
• tests/Messaging/Adapter/Email/EmailTest.php
• tests/Messaging/Adapter/Email/ResendTest.php
• tests/Messaging/Adapter/Email/SMTPTest.php
• tests/Messaging/Adapter/SMS/GEOSMS/CallingCodeTest.php
• tests/Messaging/Adapter/SMS/GEOSMSTest.php
• tests/Messaging/Adapter/SMS/SMSTest.php
• tests/Messaging/Adapter/SMS/TelnyxTest.php

🧰 Additional context used

🧬 Code graph analysis (2)

tests/Messaging/Adapter/SMS/SMSTest.php (1)

src/Utopia/Messaging/Adapter.php (1)

• getCountryCode (268-284)

tests/Messaging/Adapter/SMS/GEOSMS/CallingCodeTest.php (1)

src/Utopia/Messaging/Adapter/SMS/GEOSMS/CallingCode.php (2)

• CallingCode (10-595)
• fromPhoneNumber (576-594)

🪛 GitHub Actions: Tests

tests/Messaging/Adapter/Base.php

[error] 43-43: Email/send test assertion failed. Delivered count does not match expected. Error: 'Maximum credits exceeded'.

🔇 Additional comments (14)

tests/Messaging/Adapter/Chat/DiscordTest.php (1)

85-85: LGTM!

The switch to assertSame enforces strict type and value equality for the webhook ID, which is appropriate for string comparisons.

tests/Messaging/Adapter/SMS/SMSTest.php (1)

28-36: LGTM!

All assertions correctly upgraded to strict equality. The country code comparisons at lines 35-36 are appropriate since getCountryCode() returns ?int.

tests/Messaging/Adapter/Base.php (1)

43-45: Verify the pipeline failure on line 43.

The switch to assertSame is appropriate for enforcing strict type equality. However, the pipeline failure indicates a test environment issue: "Maximum credits exceeded". Please verify that the test environment has sufficient credits and that the API is returning the expected response structure.

tests/Messaging/Adapter/Email/EmailTest.php (1)

38-44: LGTM!

All assertions correctly upgraded to strict equality for email field comparisons.

tests/Messaging/Adapter/SMS/TelnyxTest.php (1)

23-24: Consistent update in commented code.

While this change has no runtime impact since the code is commented, updating to assertSame maintains consistency with the rest of the PR and prepares the code for when Telnyx testing numbers become available.

tests/Messaging/Adapter/SMS/GEOSMS/CallingCodeTest.php (1)

12-17: LGTM! Strict equality improves type safety.

The change from assertEquals to assertSame appropriately enforces strict type checking for calling code string constants and null values returned by fromPhoneNumber.

tests/Messaging/Adapter/SMS/GEOSMSTest.php (4)

32-33: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking for count (integer) and status (string) comparisons.

---

57-58: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking for count and status comparisons.

---

84-86: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking across all assertions in this test method.

---

111-112: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking for count and status comparisons.

tests/Messaging/Adapter/Email/SMTPTest.php (3)

38-41: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking for email field string comparisons.

---

75-78: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking for email field string comparisons.

---

113-115: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking for email field string comparisons.

tests/Messaging/Adapter/Email/ResendTest.php (1)

111-115: LGTM! Strict equality improves type safety.

The change to assertSame enforces strict type checking for deliveredTo (integer), error (string), and status (string) fields in the response.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}