Skip to content

Conversation

piiertho
Copy link
Member

This fixes graalVM native-image JNI config and ios static lib export

@piiertho piiertho requested a review from Copilot June 13, 2025 12:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the iOS static library export path and updates the GraalVM JNI configuration for improved consistency and correctness.

  • Updated version bump guide to include the new version file.
  • Modified iOS paths header to correct the library file path.
  • Revised JNI configuration JSON and removed the unused hashCode JNI binding.
  • Updated Bootstrap to use the new version constant and removed an obsolete dependency.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
versionBumpGuide.txt Added reference to the new version file.
src/lifecycle/paths.h Changed the iOS Graal native image path to remove the JVM_DIRECTORY prefix.
src/jvm_wrapper/kotlin_callable_custom.h Removed the hashCode JNI method binding.
kt/plugins/godot-gradle-plugin/src/main/resources/godot/gradle/godot-kotlin-graal-jni-config.json Renamed and added JNI configuration methods.
kt/godot-library/godot-core-library/src/main/kotlin/godot/runtime/Bootstrap.kt Updated version retrieval to use the new constant.
kt/godot-library/godot-core-library/build.gradle.kts Removed dependency on godot-build-props.
kt/common/src/main/kotlin/godot/common/Version.kt Introduced the GODOT_KOTLIN_VERSION constant.
Comments suppressed due to low confidence (1)

src/lifecycle/paths.h:39

  • Consider adding a brief comment explaining the removal of the JVM_DIRECTORY prefix for IOS_GRAAL_NATIVE_IMAGE_FILE to clarify the rationale behind this bugfix for future maintainers.
static constexpr const char* IOS_GRAAL_NATIVE_IMAGE_FILE {"usercode.a"};

@piiertho piiertho requested a review from CedNaru June 13, 2025 12:38
@piiertho piiertho merged commit 90eb483 into master Jun 30, 2025
70 checks passed
@piiertho piiertho deleted the bugfix/ios-lib-path-and-graal-jni-config branch June 30, 2025 09:49
@piiertho piiertho mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants