test(date): validate locale formats via runtime expansion #9831
+76
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoNao89
force-pushed
the
fix/macos-locale-tests-9654
branch
2 times, most recently
from
933541a to
8ab3dd6
Compare
Replace literal format code checks with validation of expanded output. Fixes test failures on macOS 15.7.2 where nl_langinfo returns composite format codes instead of explicit ones. Fixes uutils#9654
naoNao89
force-pushed
the
fix/macos-locale-tests-9654
branch
from
8ab3dd6 to
0caeab6
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to reproduce on macOS 26 but tests pass fine locally.
Fails on CI's macOS 15.7.2 though. Turns out
nl_langinforeturns different format codes across macOS versions. Fixed by validating the expanded output instead of checking literal format strings.Fixes #9654