Add nologin command
#125
Open
Add nologin command
#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Contributor
|
Can you please run |
Author
|
Done, sorry that was a basic error. |
cakebaker
reviewed
Feb 26, 2025
src/uu/nologin/output.txt
Outdated
Contributor
There was a problem hiding this comment.
What's the purpose of this file?
Author
There was a problem hiding this comment.
That was an intermediate file I didn't delete and accidentally committed (I think).
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new "nologin" command to politely refuse a login, addressing issue #8.
- Introduces a new Cargo.toml and source files for the nologin command
- Implements the command logic using clap for argument parsing and uucore for utilities
- Updates the workspace Cargo.toml to include the new command in the feat_common_core list
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/uu/nologin/Cargo.toml | New package metadata for the nologin command |
| src/uu/nologin/src/nologin.rs | Command implementation using clap and uucore, including argument parsing |
| src/uu/nologin/nologin.md | Documentation for the nologin command |
| Cargo.toml | Workspace updated to include the nologin command |
| src/uu/nologin/src/main.rs | Entry point for the nologin command |
| set_exit_code(1); | ||
|
|
||
| let args: Vec<OsString> = args.collect(); | ||
| if args.len() > 2 { |
There was a problem hiding this comment.
The condition for extra arguments simply returns Ok() without any feedback to the user. Consider adding an error message or usage info instead of silently exiting.
Suggested change
| if args.len() > 2 { | |
| if args.len() > 2 { | |
| writeln!(std::io::stderr(), "Error: too many arguments")?; | |
| writeln!(std::io::stderr(), "Usage: {}", USAGE)?; |
|
Inactive PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue #8
Implements
nologincommand. Feedback welcome, this is my first PR to this org.