Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
This fixes the
pcommand so it matches GNU sed’soutputline()behavior.write_chunk()now writes the line content without a trailing newline, and only appends\nif the original input line was newline-terminated (GNU’schomped = truecase). With this in place, thepcommand can simply callwrite_chunk()directly without any special handling.To fully mirror GNU sed, this newline logic would ideally apply to all
write_chunk()calls. However, doing so changes existing output behavior and breaks a large number of tests that currently depend on the old semantics. For now, this change is intentionally scoped topto fix the reported issue without introducing broader regressions.