[oneDPL][ranges] Add rotate and rotate_copy #640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akukanov
changed the title
akukanov
reviewed
Oct 22, 2025
Comment on lines
+558
to
+559
| rotate_copy (ExecutionPolicy&& pol, R&& r, std::ranges::iterator_t<R> middle, | ||
| OutR&& result); |
There was a problem hiding this comment.
Suggested change
| rotate_copy (ExecutionPolicy&& pol, R&& r, std::ranges::iterator_t<R> middle, | |
| OutR&& result); | |
| rotate_copy (ExecutionPolicy&& pol, R&& r, std::ranges::iterator_t<R> middle, OutR&& result); |
It should be short enough for a single line.
| std::ranges::borrowed_iterator_t<OutR>> | ||
| reverse_copy (ExecutionPolicy&& pol, R&& r, OutR&& result); | ||
| // rotate_copy |
There was a problem hiding this comment.
I suggest placing the rotate algorithms together with shift algorithms into a group of their own, named "Sequence reordering" or similarly. For the rationale, see #641 (comment)
|
The algorithms have been moved into #641. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
rotateandrotate_copyparallel range algorithms into oneDPL specification.