Replace custom tab bar with native iOS TabView #53

graycreate · 2025-10-17T11:08:50Z

Summary

Replace the custom bottom tab bar implementation with iOS native TabView component using SF Symbols icons.

Changes Made

Core Implementation

✅ Replace custom TabBar widget with native SwiftUI TabView
✅ Use SF Symbols for tab icons:
- 最新 (Feed): newspaper
- 发现 (Explore): safari
- 通知 (Message): bell with badge support
- 我 (Me): person
✅ Integrate TopBar within each tab using pageWithTopBar helper function

Code Updates

✅ MainPage.swift: Implement native TabView with selection binding
✅ FeedPage.swift: Remove .hide() modifier, move data loading to onAppear
✅ ExplorePage.swift: Remove .hide() modifier, add onAppear for data loading
✅ MessagePage.swift: Remove .hide() modifier, move data loading to onAppear
✅ MePage.swift: Remove .hide() modifier

Resource Cleanup

🗑️ Delete TabBar.swift (custom tab bar implementation, ~150 lines)
🗑️ Remove custom tab icon assets:
- feed_tab.imageset (3 PNG files + JSON)
- explore_tab.imageset (3 PNG files + JSON)
- message_tab.imageset (3 PNG files + JSON)
- me_tab.imageset (3 PNG files + JSON)

Benefits

✨ User Experience

Native iOS look and feel with standard tab bar behavior
Smooth tab switching animations
Better accessibility support
Automatic handling of safe areas and device variations

📦 Code Quality

Removed ~150 lines of custom UI code
Removed 12 custom icon asset files
Cleaner, more maintainable codebase
Uses system icons instead of custom assets

🔧 Technical

iOS 15+ compatible implementation
Native badge support for unread messages
Proper integration with SwiftUI lifecycle
Reduced maintenance burden

Testing

Build succeeds on iOS Debug configuration
App installs successfully on Gray'iPhone
All 4 tabs implemented with appropriate icons
Badge displays correctly for unread messages
Manual testing on device (requires device unlock)

Screenshots

Screenshots will be added after manual testing on device

🤖 Generated with Claude Code

Replace the custom bottom tab bar implementation with iOS native TabView component using SF Symbols icons. Changes: - Replace custom TabBar widget with native SwiftUI TabView - Use SF Symbols for tab icons (newspaper, safari, bell, person) - Add badge support for unread message count - Remove .hide() modifiers from page views (TabView handles visibility) - Move data loading logic to onAppear in each page view - Integrate TopBar within each tab using pageWithTopBar helper Cleanup: - Delete TabBar.swift (custom tab bar implementation) - Remove custom tab icon assets (feed_tab, explore_tab, message_tab, me_tab) - Removed ~150 lines of custom UI code Benefits: - Native iOS look and feel with standard tab bar behavior - Uses system SF Symbols icons instead of custom assets - Cleaner, more maintainable codebase - Better integration with iOS accessibility features - Automatic handling of safe areas and device variations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2025-10-17T11:10:18Z

Code Coverage Report ❌

Current coverage: 0%

Copilot

Pull Request Overview

Replaces the custom bottom TabBar with the native SwiftUI TabView to simplify implementation and leverage system behaviors (icons, badges, safe areas).

Introduces TabView with SF Symbols and per-tab top bar wrapper.
Removes custom .hide() based tab selection gating and shifts initial data loading to onAppear in pages.
Cleans up obsolete custom tab bar file and image assets.

Reviewed Changes

Copilot reviewed 10 out of 22 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
V2er/View/MainPage.swift	Adds native TabView with tab items and helper wrapping each page with TopBar.
V2er/View/Feed/FeedPage.swift	Removes .hide usage; adds onAppear fetch trigger.
V2er/View/Explore/ExplorePage.swift	Removes .hide; adds onAppear conditional fetch.
V2er/View/Message/MessagePage.swift	Removes .hide; adds onAppear conditional fetch.
V2er/View/Me/MePage.swift	Removes .hide call for profile tab.
V2er/View/Widget/TabBar.swift	Deletes custom tab bar implementation (now replaced).
V2er/Assets.xcassets/*_tab.imageset	Deletes obsolete custom tab icon assets.

Comments suppressed due to low confidence (1)

V2er/View/Me/MePage.swift:1

With this hide call removed, the isSelected logic in MePage (used only to support hiding) becomes unused; consider removing the isSelected computed property to reduce dead code.

//

Copilot · 2025-10-17T11:10:27Z

V2er/View/MainPage.swift

+                TabView(selection: selectedTab) {
+                    // Feed Tab
+                    pageWithTopBar(
+                        FeedPage(selecedTab: state.selectedTab)


Correct the parameter label 'selecedTab' to 'selectedTab' to avoid propagating the typo; update the corresponding parameter name in each page's initializer.

Copilot · 2025-10-17T11:10:28Z

V2er/View/MainPage.swift

+
+                    // Explore Tab
+                    pageWithTopBar(
+                        ExplorePage(selecedTab: state.selectedTab)


Correct the parameter label 'selecedTab' to 'selectedTab' to avoid propagating the typo; update the corresponding parameter name in each page's initializer.

Copilot · 2025-10-17T11:10:28Z

V2er/View/MainPage.swift

+
+                    // Message Tab
+                    pageWithTopBar(
+                        MessagePage(selecedTab: state.selectedTab)


Correct the parameter label 'selecedTab' to 'selectedTab' to avoid propagating the typo; update the corresponding parameter name in each page's initializer.

Copilot · 2025-10-17T11:10:28Z

V2er/View/MainPage.swift

+
+                    // Me Tab
+                    pageWithTopBar(
+                        MePage(selecedTab: state.selectedTab)


Correct the parameter label 'selecedTab' to 'selectedTab' to avoid propagating the typo; update the corresponding parameter name in each page's initializer.

Copilot · 2025-10-17T11:10:28Z

V2er/View/Feed/FeedPage.swift

            .onAppear {
                log("FeedPage.onAppear")
+                if !state.hasLoadedOnce {
+                    dispatch(FeedActions.FetchData.Start(autoLoad: true))
+                }


Fetch is already conditionally dispatched inside the existing isSelected computed property; adding the same conditional fetch in onAppear risks double dispatch and duplicate network requests. Remove one of the two triggers (prefer a single source, e.g. keep onAppear and simplify isSelected or vice versa).

Copilot · 2025-10-17T11:10:29Z

V2er/View/Explore/ExplorePage.swift

+        .onAppear {
+            if !state.hasLoadedOnce {
+                dispatch(ExploreActions.FetchData.Start(autoLoad: true))
+            }
+        }


ExplorePage already dispatches the same initial fetch inside isSelected when the tab becomes active; this added onAppear block duplicates that logic and can cause redundant requests. Consolidate to a single initiation point.

Suggested change

.onAppear {

if !state.hasLoadedOnce {

dispatch(ExploreActions.FetchData.Start(autoLoad: true))

}

}

Copilot · 2025-10-17T11:10:29Z

V2er/View/Message/MessagePage.swift

+            .onAppear {
+                if !state.hasLoadedOnce {
+                    dispatch(MessageActions.FetchStart(autoLoad: true))
+                }
+            }


MessagePage also conditionally dispatches the same fetch in isSelected; retaining both paths may cause duplicate initial loads. Remove one of them to avoid unnecessary network calls.

Remove all references to the deleted TabBar.swift file from the Xcode project.pbxproj file to fix build failure. - Remove PBXBuildFile reference - Remove PBXFileReference - Remove from Widget group children - Remove from PBXSourcesBuildPhase Fixes CI build error: "Build input file cannot be found: TabBar.swift" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2025-10-17T11:13:49Z

Code Coverage Report ❌

Current coverage: 0%

Restore the TabId enum definition that was removed with TabBar.swift. The enum is now defined in GlobalState.swift where it's primarily used. Fixes build errors: "cannot find type 'TabId' in scope" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2025-10-17T11:16:04Z

Code Coverage Report ❌

Current coverage: 0%

Copilot

Pull Request Overview

Copilot reviewed 12 out of 24 changed files in this pull request and generated 5 comments.

Copilot · 2025-10-17T11:16:51Z

V2er/View/MainPage.swift

+                TabView(selection: selectedTab) {
+                    // Feed Tab
+                    pageWithTopBar(
+                        FeedPage(selecedTab: state.selectedTab)


The parameter name 'selecedTab' is misspelled; rename to 'selectedTab' for clarity and consistency.

Copilot · 2025-10-17T11:16:51Z

V2er/View/MainPage.swift

+
+                    // Explore Tab
+                    pageWithTopBar(
+                        ExplorePage(selecedTab: state.selectedTab)


The parameter name 'selecedTab' is misspelled; rename to 'selectedTab' for clarity and consistency.

Copilot · 2025-10-17T11:16:51Z

V2er/View/MainPage.swift

+
+                    // Message Tab
+                    pageWithTopBar(
+                        MessagePage(selecedTab: state.selectedTab)


The parameter name 'selecedTab' is misspelled; rename to 'selectedTab' for clarity and consistency.

Copilot · 2025-10-17T11:16:51Z

V2er/View/MainPage.swift

+
+                    // Me Tab
+                    pageWithTopBar(
+                        MePage(selecedTab: state.selectedTab)


The parameter name 'selecedTab' is misspelled; rename to 'selectedTab' for clarity and consistency.

Copilot · 2025-10-17T11:16:52Z

V2er/View/Feed/FeedPage.swift

            .onAppear {
                log("FeedPage.onAppear")
+                if !state.hasLoadedOnce {
+                    dispatch(FeedActions.FetchData.Start(autoLoad: true))
+                }
            }


Initial fetch is already triggered in the existing isSelected computed property; this added onAppear block can cause duplicate dispatches (two initial network requests). Remove either the isSelected-triggered fetch or this onAppear block.

Suggested change

.onAppear {

log("FeedPage.onAppear")

if !state.hasLoadedOnce {

dispatch(FeedActions.FetchData.Start(autoLoad: true))

}

}

Copilot AI review requested due to automatic review settings October 17, 2025 11:08

github-actions bot added the size/L label Oct 17, 2025

Copilot AI reviewed Oct 17, 2025

View reviewed changes

github-actions bot added size/L and removed size/L labels Oct 17, 2025

Copilot AI review requested due to automatic review settings October 17, 2025 11:15

github-actions bot added size/L and removed size/L labels Oct 17, 2025

Copilot AI reviewed Oct 17, 2025

View reviewed changes

graycreate merged commit 20050d7 into main Oct 17, 2025
6 checks passed

graycreate deleted the feature/replace-custom-tabbar-with-native branch October 17, 2025 11:37

Replace custom tab bar with native iOS TabView #53

Replace custom tab bar with native iOS TabView #53

Uh oh!

Conversation

graycreate commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Core Implementation

Code Updates

Resource Cleanup

Benefits

Testing

Screenshots

Uh oh!

github-actions bot commented Oct 17, 2025

Code Coverage Report ❌

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 17, 2025

Code Coverage Report ❌

Uh oh!

github-actions bot commented Oct 17, 2025

Code Coverage Report ❌

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

graycreate commented Oct 17, 2025 •

edited

Loading