Skip to content

feat(isBase64) #2491 #2573 Simplify isBase64 to prevent stack overflow #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KrayzeeKev
Copy link

Solves #2491 and #2573
Separate length check and then simplify regex to match any number of valid characters and 0 to 2 = on the end. Length check will ensure the {4} grouping is no longer necessary.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72573b3) to head (e947d6f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2574   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2536    +1     
  Branches       641       642    +1     
=========================================
+ Hits          2535      2536    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KrayzeeKev
Copy link
Author

Who is able to provide additional approvals and get this published? We've got production issues as a result of this. Need to decide whether we downgrade or hold out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants