Latest changes from PostgresNIO connection pool

[adam-fowler]

Changes include
vapor/postgres-nio#552
vapor/postgres-nio#563
vapor/postgres-nio#559
vapor/postgres-nio#571
vapor/postgres-nio#572

Had to update ValkeyNodeClient to use new ConnectionLease

[github-actions]

❌ Benchmark comparison failed with error ❌

Summary

===============================================================
Threshold deviations for ValkeyBenchmarks:Client: GET benchmark
===============================================================

Malloc (total) (K, %)	main	pull_request	Difference %	Threshold %
p25	84	77	-8	5
p50	85	78	-7	5
p75	86	80	-6	5

=========================================================================================================
Threshold deviations for ValkeyBenchmarks:Client: GET benchmark | parallel 20 | 20 concurrent connections
=========================================================================================================

Malloc (total) (K, %)	main	pull_request	Difference %	Threshold %
p25	101	78	-22	5
p50	104	80	-22	5
p75	107	82	-23	5

New baseline 'pull_request' is BETTER than the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '6293f272fd89' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	84	84	85	86	87	87	87	6
pull_request	76	77	78	80	83	83	83	6
Δ	-8	-7	-7	-6	-4	-4	-4	0
Improvement %	10	8	8	7	5	5	5	0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	96	101	104	107	111	111	111	24
pull_request	70	78	80	82	84	87	87	28
Δ	-26	-23	-24	-25	-27	-24	-24	4
Improvement %	27	23	23	23	24	22	22	4

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	4	4	8
pull_request	4	4	4	4	4	4	4	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	7	8	8	10	11	11	11	8
pull_request	7	8	8	10	11	11	11	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	33	34	34	34	34	6
pull_request	33	33	33	34	34	34	34	6
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	33	34	34	34	34	6
pull_request	33	33	33	34	34	34	34	6
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	19
pull_request	0	0	0	0	0	0	0	19
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	746
pull_request	0	0	0	0	0	0	0	740
Δ	0	0	0	0	0	0	0	-6
Improvement %	0	0	0	0	0	0	0	-6

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	1899
pull_request	0	0	0	0	0	0	0	1890
Δ	0	0	0	0	0	0	0	-9
Improvement %	0	0	0	0	0	0	0	-9

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	360
pull_request	0	0	0	0	0	0	0	360
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

[adam-fowler]

Annoyingly the benchmark script returns an error when the benchmarks improve

[nilanshu-sharma]

LGTM