-
Notifications
You must be signed in to change notification settings - Fork 15
Add Support for Numbered Databases #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Pull request no significant performance differences ✅ SummaryNew baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Full Benchmark ComparisonComparing results between 'main' and 'pull_request'ValkeyBenchmarksClient: GET benchmark metricsMalloc (total): results within specified thresholds, fold down for details.
Client: GET benchmark | parallel 20 | 20 concurrent connections metricsMalloc (total): results within specified thresholds, fold down for details.
Connection: GET benchmark metricsMalloc (total): results within specified thresholds, fold down for details.
Connection: GET benchmark – NoOpTracer metricsMalloc (total): results within specified thresholds, fold down for details.
Connection: Pipeline array benchmark metricsMalloc (total): results within specified thresholds, fold down for details.
Connection: Pipeline benchmark metricsMalloc (total): results within specified thresholds, fold down for details.
HashSlot – {user}.whatever metricsMalloc (total): results within specified thresholds, fold down for details.
ValkeyCommandEncoder – Command with 7 words metricsMalloc (total): results within specified thresholds, fold down for details.
ValkeyCommandEncoder – Simple GET metricsMalloc (total): results within specified thresholds, fold down for details.
ValkeyCommandEncoder – Simple MGET 15 keys metricsMalloc (total): results within specified thresholds, fold down for details.
|
adam-fowler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good. Minor naming issue. I'd rather full descriptive variable names without acronyms.
|
Soundness API breakage check failing because the initializer signature got modified with the introduction of new field |
|
@nilanshu-sharma You need to sign off each of your commits. ie add You can add this text automatically using |
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
Signed-off-by: Nilanshu Sharma <nilanshu_sharma@apple.com>
dbf5040 to
32f43ee
Compare
Singed off all the commits in this PR. |
Adding Numbered Database support as requested in the issue#231
dbNumfield inValkeyClientConfigurationdbNumis then propragated toValkeyConnectionConfigurationdbNumis then used to runSELECTinValkeyChannelHandler.setConnected()Added Integration test to verify selecting all default available 16 databases and doing operations against them.