Skip to content

fix: parse boolean and int attributes value #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: parse boolean and int attributes value #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/lazyframe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,35 @@ const Lazyframe = () => {

}

function parseBoolValue(inputString, defaultVal) {
if (inputString === 'true') {
return true;
}
if (inputString === 'false') {
return false;
}
return defaultVal;
}

function parseIntValue(inputString, defaultVal) {
const val = parseInt(inputString);
return isNaN(val) ? defaultVal: val;
}

function setup(el) {

const attr = Array.prototype.slice.apply(el.attributes)
.filter(att => att.value !== '')
.reduce((obj, curr) => {
let name = curr.name.indexOf('data-') === 0 ? curr.name.split('data-')[1] : curr.name;
obj[name] = curr.value;
let val = curr.value;
if (['autoplay','initinview'].includes(name)) {
val = parseBoolValue(val, settings[name])
}
if (['debounce'].includes(name)) {
val = parseIntValue(val, settings[name])
}
obj[name] = val;
return obj;
}, {});

Expand Down