[model] add support for mixtral moe model #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guocuimi
reviewed
Apr 22, 2024
| const int64_t head_dim = args.head_dim(); | ||
| const int64_t n_kv_heads = args.n_kv_heads().value_or(n_heads); | ||
| const int64_t n_local_heads = n_heads / world_size; | ||
| const int64_t n_local_kv_heads = n_kv_heads / world_size; |
There was a problem hiding this comment.
just a heads up. i added support for MQA and GQA, please also include that support in your change. FYI dff774e
you can learn MQA and GQA from this blog: https://iamshobhitagarwal.medium.com/navigating-the-attention-landscape-mha-mqa-and-gqa-decoded-288217d0a7d1
936187425
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for Mixtral-8x7B-v0.1