Skip to content

Conversation

@TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Dec 18, 2025

Fixes biome lint error

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: 54b9f63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
workflow Patch
@workflow/astro Patch
@workflow/sveltekit Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Dec 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Dec 18, 2025 11:39pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Dec 18, 2025 11:39pm
example-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-astro-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-express-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-fastify-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-hono-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-nitro-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-nuxt-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workbench-vite-workflow Ready Ready Preview, Comment Dec 18, 2025 11:39pm
workflow-docs Ready Ready Preview, Comment Dec 18, 2025 11:39pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

🧪 E2E Test Results

Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 286 0 11 297
✅ 💻 Local Development 262 0 8 270
❌ 📦 Local Production 260 2 8 270
✅ 🐘 Local Postgres 262 0 8 270
✅ 🪟 Windows 27 0 0 27
❌ 🌍 Community Worlds 109 11 0 120
Total 1206 13 35 1254

❌ Failed Tests

📦 Local Production (2 failed)

astro-stable (1 failed):

  • webhookWorkflow

sveltekit-stable (1 failed):

  • webhookWorkflow
🌍 Community Worlds (11 failed)

mongodb (1 failed):

  • webhookWorkflow

redis (1 failed):

  • webhookWorkflow

starter (8 failed):

  • addTenWorkflow
  • addTenWorkflow
  • retryAttemptCounterWorkflow
  • crossFileErrorWorkflow - stack traces work across imported modules
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step

turso (1 failed):

  • webhookWorkflow

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 26 0 1
✅ example 26 0 1
✅ express 26 0 1
✅ fastify 26 0 1
✅ hono 26 0 1
✅ nextjs-turbopack 26 0 1
✅ nextjs-webpack 26 0 1
✅ nitro 26 0 1
✅ nuxt 26 0 1
✅ sveltekit 26 0 1
✅ vite 26 0 1
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 26 0 1
✅ express-stable 26 0 1
✅ fastify-stable 26 0 1
✅ hono-stable 26 0 1
✅ nextjs-turbopack-stable 27 0 0
✅ nextjs-webpack-stable 27 0 0
✅ nitro-stable 26 0 1
✅ nuxt-stable 26 0 1
✅ sveltekit-stable 26 0 1
✅ vite-stable 26 0 1
❌ 📦 Local Production
App Passed Failed Skipped
❌ astro-stable 25 1 1
✅ express-stable 26 0 1
✅ fastify-stable 26 0 1
✅ hono-stable 26 0 1
✅ nextjs-turbopack-stable 27 0 0
✅ nextjs-webpack-stable 27 0 0
✅ nitro-stable 26 0 1
✅ nuxt-stable 26 0 1
❌ sveltekit-stable 25 1 1
✅ vite-stable 26 0 1
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 26 0 1
✅ express-stable 26 0 1
✅ fastify-stable 26 0 1
✅ hono-stable 26 0 1
✅ nextjs-turbopack-stable 27 0 0
✅ nextjs-webpack-stable 27 0 0
✅ nitro-stable 26 0 1
✅ nuxt-stable 26 0 1
✅ sveltekit-stable 26 0 1
✅ vite-stable 26 0 1
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 27 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 3 0 0
❌ mongodb 26 1 0
✅ redis-dev 3 0 0
❌ redis 26 1 0
✅ starter-dev 3 0 0
❌ starter 19 8 0
✅ turso-dev 3 0 0
❌ turso 26 1 0

📋 View full workflow run


Some E2E test jobs failed:

  • Vercel Prod: success
  • Local Dev: success
  • Local Prod: failure
  • Local Postgres: success
  • Windows: success

Check the workflow run for details.

Copy link
Member Author

TooTallNate commented Dec 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TooTallNate TooTallNate marked this pull request as ready for review December 18, 2025 22:16
Copilot AI review requested due to automatic review settings December 18, 2025 22:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a biome lint error by renaming function parameters from globalThis to global to avoid shadowing the JavaScript global globalThis object.

Key changes:

  • Renamed globalThis parameter to global in ProcessHookParams and ProcessStepParams interfaces
  • Updated all function parameters and references throughout the suspension handler
  • Moved @opentelemetry/api import to the top for better organization

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/core/src/runtime/suspension-handler.ts Renamed globalThis parameter to global in interfaces and functions to avoid shadowing the global object
.changeset/grumpy-apes-rescue.md Added changeset documenting the fix

The changes are consistent and complete. All references to the renamed parameter have been properly updated, and the naming choice global aligns with the existing codebase pattern (e.g., WorkflowSuspension constructor in global.ts already uses global as the parameter name). No issues were identified.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TooTallNate TooTallNate changed the base branch from 12-18-add_retry_logic_to_world_operations to graphite-base/649 December 18, 2025 23:37
@TooTallNate TooTallNate force-pushed the 12-18-don_t_shadow_globalthis_ branch from 8d6e98b to 54b9f63 Compare December 18, 2025 23:37
@TooTallNate TooTallNate changed the base branch from graphite-base/649 to main December 18, 2025 23:37
@TooTallNate TooTallNate merged commit eaf9aa6 into main Dec 18, 2025
57 of 95 checks passed
@TooTallNate TooTallNate deleted the 12-18-don_t_shadow_globalthis_ branch December 18, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants