-
Notifications
You must be signed in to change notification settings - Fork 148
Don't shadow globalThis
#649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 54b9f63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests📦 Local Production (2 failed)astro-stable (1 failed):
sveltekit-stable (1 failed):
🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
❌ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a biome lint error by renaming function parameters from globalThis to global to avoid shadowing the JavaScript global globalThis object.
Key changes:
- Renamed
globalThisparameter toglobalinProcessHookParamsandProcessStepParamsinterfaces - Updated all function parameters and references throughout the suspension handler
- Moved
@opentelemetry/apiimport to the top for better organization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/core/src/runtime/suspension-handler.ts |
Renamed globalThis parameter to global in interfaces and functions to avoid shadowing the global object |
.changeset/grumpy-apes-rescue.md |
Added changeset documenting the fix |
The changes are consistent and complete. All references to the renamed parameter have been properly updated, and the naming choice global aligns with the existing codebase pattern (e.g., WorkflowSuspension constructor in global.ts already uses global as the parameter name). No issues were identified.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fb3505c to
f03a56c
Compare
a02365b to
6cd1a47
Compare
8d6e98b to
54b9f63
Compare

Fixes
biome linterror