[APP-14690] Add APIKey to CloudConfig in Provisioning API #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbotros
added
the
ready-for-protos
danielbotros
changed the title
edobranov
approved these changes
Dec 17, 2025
jr22
reviewed
Dec 17, 2025
Comment on lines
86
to
89
| message APIKey { | ||
| string id = 1; | ||
| string value = 2; | ||
| } |
Member
There was a problem hiding this comment.
can we make this key instead of value to match our other api key protos?
Suggested change
| message APIKey { | |
| string id = 1; | |
| string value = 2; | |
| } | |
| message APIKey { | |
| string id = 1; | |
| string key = 2; | |
| } |
here for example:
api/proto/viam/app/v1/app.proto
Lines 926 to 930 in 1119123
jr22
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
APP-14690 Add APIKey to CloudConfig in Provisioning API