Skip to content

Support for absolute URLs, HEAD request and public tus upload #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyts93 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for absolute URLs, HEAD request and public tus upload #339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3060c6
Update Vimeo.php
andyts93 Mar 28, 2025
0151a4f
Update Vimeo.php
andyts93 Mar 28, 2025
f302847
Update Vimeo.php
andyts93 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Vimeo/Vimeo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,11 @@ public function __construct(string $client_id, string $client_secret, string $ac
* @param string $method The HTTP Method of the request
* @param bool $json_body
* @param array $headers An array of HTTP headers to pass along with the request.
* @param bool $absoluteUrl
* @return array This array contains three keys, 'status' is the status code, 'body' is an object representation of the json response body, and headers are an associated array of response headers
* @throws VimeoRequestException
*/
public function request($url, $params = array(), $method = 'GET', $json_body = true, array $headers = array()): array
public function request($url, $params = array(), $method = 'GET', $json_body = true, array $headers = array(), bool $absoluteUrl = false): array
{
$headers = array_merge(array(
'Accept' => self::VERSION_STRING,
Expand Down Expand Up @@ -120,7 +121,10 @@ public function request($url, $params = array(), $method = 'GET', $json_body = t
$query_component = '';
}

$curl_url = self::ROOT_ENDPOINT . $url . $query_component;
$curl_url = (!$absoluteUrl ? self::ROOT_ENDPOINT : '') . $url . $query_component;
$curl_opts = array(
CURLOPT_CUSTOMREQUEST => $method,
);
break;

case 'POST':
Expand All @@ -134,7 +138,7 @@ public function request($url, $params = array(), $method = 'GET', $json_body = t
$body = http_build_query($params, '', '&');
}

$curl_url = self::ROOT_ENDPOINT . $url;
$curl_url = (!$absoluteUrl ? self::ROOT_ENDPOINT : '') . $url;
$curl_opts = array(
CURLOPT_POST => true,
CURLOPT_CUSTOMREQUEST => $method,
Expand Down Expand Up @@ -579,7 +583,7 @@ private function _authHeader(): string
* @return string
* @throws VimeoUploadException
*/
private function perform_upload_tus(string $file_path, $file_size, array $attempt): string
public function perform_upload_tus(string $file_path, $file_size, array $attempt): string
{
$default_chunk_size = (100 * 1024 * 1024); // 100 MB

Expand Down