Skip to content

feat: Add Python 3.14 freethreaded support #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

feat: Add Python 3.14 freethreaded support #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51ca7a0
feat: Add Python 3.14 freethreaded support
vinitkumar Oct 8, 2025
d6e42b9
Update Python testing matrix with latest versions and OS compatibility
vinitkumar Oct 8, 2025
4641475
fix: don't hardcode version number
vinitkumar Oct 8, 2025
6e6887f
Fix GitHub Actions Python 3.14.0-freethreaded setup issues
vinitkumar Oct 8, 2025
eec8989
Modernize all GitHub Actions workflows to use uv
vinitkumar Oct 8, 2025
67c2ff3
Fix GitHub Actions to avoid externally managed Python error
vinitkumar Oct 8, 2025
ebc393e
Fix freethreaded Python 3.14 CI workflow
vinitkumar Oct 8, 2025
889b14e
Add --system flag to all uv pip install commands
vinitkumar Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .coverage
View file
Open in desktop
Binary file not shown.
22 changes: 16 additions & 6 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,14 @@ jobs:
uses: actions/setup-python@v5.2.0
with:
python-version: "3.13"
cache: 'pip'
- run: |
python -m pip install --upgrade pip
pip install ruff

- name: Install uv
uses: astral-sh/setup-uv@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

with:
enable-cache: true

- name: Install ruff
run: uv pip install ruff
- name: Run Ruff
run: |
ruff check json2xml
Expand All @@ -37,8 +41,14 @@ jobs:
uses: actions/setup-python@v5.2.0
with:
python-version: '3.13'
cache: 'pip'
- run: pip install --upgrade mypy types-requests types-urllib3

- name: Install uv
uses: astral-sh/setup-uv@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

with:
enable-cache: true

- name: Install mypy and types
run: uv pip install mypy types-requests types-urllib3
- name: mypy
uses: liskin/gh-problem-matcher-wrap@v2
with:
Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/publish-to-live-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@ jobs:
steps:
- uses: actions/checkout@v4.1.7
- name: Set up Python 3.12
uses: actions/setup-python@v3
uses: actions/setup-python@v5.2.0
with:
python-version: '3.12'

- name: Install pypa/build
run: >-
python -m
pip install
build
--user
- name: Install uv
uses: astral-sh/setup-uv@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

with:
enable-cache: true

- name: Install build dependencies
run: uv pip install build
- name: Build a binary wheel and a source tarball
run: >-
python -m
Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/publish-to-test-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,17 @@ jobs:
steps:
- uses: actions/checkout@v4.1.7
- name: Set up Python 3.12
uses: actions/setup-python@v3
uses: actions/setup-python@v5.2.0
with:
python-version: '3.12'

- name: Install pypa/build
run: >-
python -m
pip install
build
--user
- name: Install uv
uses: astral-sh/setup-uv@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

with:
enable-cache: true

- name: Install build dependencies
run: uv pip install build
- name: Build a binary wheel and a source tarball
run: >-
python -m
Expand Down
77 changes: 73 additions & 4 deletions .github/workflows/pythonpackage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [pypy-3.10, pypy-3.11, '3.10', '3.11', '3.12', '3.13', '3.14']
python-version: [pypy-3.10, pypy-3.11, '3.10', '3.11', '3.12', '3.13', '3.14.0']
os: [
ubuntu-latest,
windows-latest,
macos-latest,
ubuntu-22.04,
windows-2022,
macos-14,
]
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -142,3 +142,72 @@ jobs:
- name: Run mypy
run: mypy json2xml tests

test-freethreaded:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
include:
- os: ubuntu-22.04
python-version: '3.14.0'
- os: windows-2022
python-version: '3.14.0'
- os: macos-14
python-version: '3.14.0'
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up Python ${{ matrix.python-version }} (freethreaded)
uses: actions/setup-python@v5.2.0
with:
python-version: '3.14t'
allow-prereleases: true

- name: Verify freethreaded Python
shell: bash
run: |
python -c "import sys; print(f'Python {sys.version}'); print(f'GIL enabled: {sys._is_gil_enabled()}' if hasattr(sys, '_is_gil_enabled') else 'GIL check not available')"

- name: Install uv
uses: astral-sh/setup-uv@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

with:
enable-cache: true
cache-dependency-glob: |
requirements*.txt
requirements-dev.in
pyproject.toml

- name: Install dependencies
run: |
uv pip install --system -e .
uv pip install --system pytest pytest-xdist pytest-cov

- name: Create coverage directory
shell: bash
run: mkdir -p coverage/reports

- name: Run tests with freethreaded Python
run: |
pytest --cov=json2xml --cov-report=xml:coverage/reports/coverage.xml --cov-report=term -xvs tests -n auto
env:
PYTHONPATH: ${{ github.workspace }}
PYTHON_FREETHREADED: 1

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

if: success()
with:
directory: ./coverage/reports/
env_vars: OS,PYTHON
fail_ci_if_error: false
files: ./coverage/reports/coverage.xml
flags: freethreaded
token: ${{ secrets.CODECOV_TOKEN }}
name: codecov-freethreaded
verbose: true
env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}-freethreaded

4 changes: 3 additions & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ json2xml

.. image:: https://github.com/vinitkumar/json2xml/actions/workflows/pythonpackage.yml/badge.svg
.. image:: https://img.shields.io/pypi/pyversions/json2xml.svg
.. image:: https://img.shields.io/badge/python-3.14%20freethreaded-blue
.. image:: https://readthedocs.org/projects/json2xml/badge/?version=latest
:target: https://json2xml.readthedocs.io/en/latest/?badge=latest
:alt: Documentation Status
Expand Down Expand Up @@ -36,6 +37,7 @@ json2xml supports the following features:
* Conversion from a `json` string to XML
* Conversion from a `json` file to XML
* Conversion from an API that emits `json` data to XML
* Full compatibility with Python 3.14 freethreaded (GIL-free) builds

Usage
^^^^^
Expand Down Expand Up @@ -194,7 +196,7 @@ in case any of the input(file, string or API URL) returns invalid JSON.
Development
^^^^^^^^^^^

This project uses modern Python development practices. Here's how to set up a development environment:
This project uses modern Python development practices and supports both regular and freethreaded Python 3.14. Here's how to set up a development environment:

.. code-block:: console

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ classifiers = [
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: CPython :: 3.14",
"Programming Language :: Python :: Implementation :: PyPy",
"Topic :: Software Development :: Libraries :: Python Modules"
]
Expand Down
Loading