Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

add stable os label kubernetes.io/os #43

Open
mingqishao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add stable os label kubernetes.io/os #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions internal/commands/root/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

const osLabel = "beta.kubernetes.io/os"
const betaOsLabel = "beta.kubernetes.io/os"
const stableOsLabel = "kubernetes.io/os"

// NodeFromProvider builds a kubernetes node object from a provider
// This is a temporary solution until node stuff actually split off from the provider interface itself.
Expand Down Expand Up @@ -58,8 +59,11 @@ func NodeFromProvider(ctx context.Context, name string, taint *v1.Taint, p provi
}

p.ConfigureNode(ctx, node)
if _, ok := node.ObjectMeta.Labels[osLabel]; !ok {
node.ObjectMeta.Labels[osLabel] = strings.ToLower(node.Status.NodeInfo.OperatingSystem)
if _, ok := node.ObjectMeta.Labels[betaOsLabel]; !ok {
node.ObjectMeta.Labels[betaOsLabel] = strings.ToLower(node.Status.NodeInfo.OperatingSystem)
}
if _, ok := node.ObjectMeta.Labels[stableOsLabel]; !ok {
node.ObjectMeta.Labels[stableOsLabel] = strings.ToLower(node.Status.NodeInfo.OperatingSystem)
}
return node
}
Expand Down